[webkit-reviews] review denied: [Bug 37059] SheriffBot should force_build builders that are idle and have failed exactly once : [Attachment 52488] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 37059: SheriffBot should force_build builders that are idle and have failed
exactly once
https://bugs.webkit.org/show_bug.cgi?id=37059

Attachment 52488: Patch
https://bugs.webkit.org/attachment.cgi?id=52488&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Why the crazy caching?
 109	 def provoke_flaky_builders(self, revisions_causing_failures=None):
 110	     if revisions_causing_failures == None:
 111		 revisions_causing_failures =
self._tool.buildbot.revisions_causing_failures()

I give you {}.values()
116	    failed_builder_names = \
 117		 set([revisions_causing_failures[key].name()
 118		      for key in revisions_causing_failures.keys()])

the red_idle_builders code should be its own function.

Otherwise looks OK.