[webkit-reviews] review requested: [Bug 37125] Enable setting MOBILE flag at build time : [Attachment 52587] 1st try, remove the define
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 5 16:30:30 PDT 2010
Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked for review:
Bug 37125: Enable setting MOBILE flag at build time
https://bugs.webkit.org/show_bug.cgi?id=37125
Attachment 52587: 1st try, remove the define
https://bugs.webkit.org/attachment.cgi?id=52587&action=review
------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
Alternatively we can put the define around guards like other feature flags,
like this:
#ifndef MOBILE
#define MOBILE 0
#endif
I'm also happy to change the name of the define if there is a better proposal.
I think a global define like MOBILE does not quite make sense.
More information about the webkit-reviews
mailing list