[webkit-reviews] review requested: [Bug 37060] List item markers are not always updated after changes in the DOM : [Attachment 52569] patch

[bugzilla-daemon at webkit.org]

Jakub Wieczorek <jwieczorek at webkit.org> has asked  for review:
Bug 37060: List item markers are not always updated after changes in the DOM
https://bugs.webkit.org/show_bug.cgi?id=37060

Attachment 52569: patch
https://bugs.webkit.org/attachment.cgi?id=52569&action=review

------- Additional Comments from Jakub Wieczorek <jwieczorek at webkit.org>
(In reply to comment #24)
> > gchar* webkit_web_frame_marker_text_for_list_item(WebKitWebFrame* frame,
JSObjectRef nodeObject);
> 
> You changed the actual function to take a JSValueRef, but this extra
definition
> still has the old signature. I don't know why this definition has to be here,

> but this is why the GTK build is failing.

Yeah, it's not in the public headers. Thanks!
I just finished a local build to make sure it builds fine on GTK+.

I looked at a diff between the patch that built on win and the last one, and I
suspect this is what breaks it:

+	 RenderListItem* item = toRenderListItem(renderer);
+	 Node* otherList = enclosingList(item);
	 // This item is part of our current list, so it's what we're looking
for.
	 if (list == otherList)
-	     return toRenderListItem(renderer);
+	     return item;

This one should fix it.

Thanks for your patience. :) And yay for the EWS!