[webkit-reviews] review denied: [Bug 36690] [Qt] LayoutTests/http/tests/appcache/resource-redirect-2.html failed and skipped : [Attachment 52447] Patch file adhereing to style rules

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 5 13:03:12 PDT 2010


Laszlo Gombos <laszlo.1.gombos at nokia.com> has denied
krithigassree.sambamurthy at nokia.com's request for review:
Bug 36690: [Qt] LayoutTests/http/tests/appcache/resource-redirect-2.html failed
and skipped
https://bugs.webkit.org/show_bug.cgi?id=36690

Attachment 52447: Patch file adhereing to  style rules
https://bugs.webkit.org/attachment.cgi?id=52447&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
r- as this now has to be reworked after fix for 37097 is landed. The same bug
(missing feature) cause both xhr and app cache failures. 

Bug 37097 is using 10 as a redirect limit, I'm ok with that instead of 16
proposed as part of this patch.

Krithiga, can you rewor your patch so that it works on top of patch for bug
37097. I think your error handling code and the Skipped list update is still
needed.


More information about the webkit-reviews mailing list