[webkit-reviews] review requested: [Bug 37025] Web Inspector: GC Run event should be added to Timeline Panel : [Attachment 52555] [patch] Third iteration.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 5 12:08:20 PDT 2010


Ilya Tikhonovsky <loislo at chromium.org> has asked  for review:
Bug 37025: Web Inspector: GC Run event should be added to Timeline Panel
https://bugs.webkit.org/show_bug.cgi?id=37025

Attachment 52555: [patch] Third iteration.
https://bugs.webkit.org/attachment.cgi?id=52555&action=review

------- Additional Comments from Ilya Tikhonovsky <loislo at chromium.org>
1) GCRun events data container was moved from ScriptGCEventHelper to
InspectorTimelineAgent;
2) all active Timeline agents will receive GCRun events data when GCRun event
happen;
3) as far as we can't use ScriptObject when GC Run event happen TimelineAgent
will use Vector to store GC Run event data
4) Bug with Epilogue/Prologue deregistration was fixed.


More information about the webkit-reviews mailing list