[webkit-reviews] review denied: [Bug 37097] [Qt] Fix infinite redirection loop in QNetworkReplyHandler : [Attachment 52546] User Counters

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Robert Hogan
<robert at webkit.org>'s request for review:
Bug 37097: [Qt] Fix infinite redirection loop in QNetworkReplyHandler
https://bugs.webkit.org/show_bug.cgi?id=37097

Attachment 52546: User Counters
https://bugs.webkit.org/attachment.cgi?id=52546&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
I did a bit of research and Mozilla doesn't verify where the redirect comes
from, and your patch won't handles cases as page1 -> page2 -> page1!

Let's introduce a max redirection count (default 10 as Mozilla) and count it
down for each redirect (not just the case of newUrl == m_reply->url()).

When it reaches 0, we fail with an error such as "Redirection limit reached!"
or similar. Later we can add a setting for this.

Info: http://kb.mozillazine.org/Network.http.redirection-limit (look at the bug
report)