[webkit-reviews] review denied: [Bug 37097] [Qt] Fix infinite redirection loop in QNetworkReplyHandler : [Attachment 52540] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Robert Hogan
<robert at webkit.org>'s request for review:
Bug 37097: [Qt] Fix infinite redirection loop in QNetworkReplyHandler
https://bugs.webkit.org/show_bug.cgi?id=37097

Attachment 52540: Patch
https://bugs.webkit.org/attachment.cgi?id=52540&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>

> +	   QUrl newUrl = m_reply->url().resolved(redirection);
> +	   if (newUrl == m_reply->url()) { // Infinite redirection loop!

 // avoid redirecting to the same url as it causes infinite recursion


> +	       ResourceError error(newUrl.host(), 400 /*bad request*/,
> +				   newUrl.toString(),
> +				   QCoreApplication::translate("QWebPage",
"Ininite Loop in Redirect Request"));

Spelling issue. "Infinite recursion in redirection request"

> +	       client->didFail(m_resourceHandle, error);
> +	       return;
> +	   }
> +
>	   m_redirected = true;
>  
> -	   QUrl newUrl = m_reply->url().resolved(redirection);
>	   ResourceRequest newRequest = m_resourceHandle->request();
>	   newRequest.setURL(newUrl);
>  
> -- 
> 1.6.3.3
>