[webkit-reviews] review granted: [Bug 37052] [V8] Extend the set of types supported by SerializedScriptValue : [Attachment 52472] patch v1

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Vitaly Repeshko
<vitalyr at chromium.org>'s request for review:
Bug 37052: [V8] Extend the set of types supported by SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=37052

Attachment 52472: patch v1
https://bugs.webkit.org/attachment.cgi?id=52472&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
> -	       push(new ObjectState(handleCast<v8::Object>(value)));
> -	       // FIXME:
> -	       // - check not a wrapper
> -	       // - support File, ImageData, etc.
> -	   }
> -	   return true;
Please file a bug for the FIXME.

> +    static StateBase* newArrayState(v8::Handle<v8::Array> array, StateBase*
next)
> +    {
> +	   // FIXME: use plain Array state when we can quickly check that
> +	   // an array is not sparse and has only indexed properties.
> +	   return new SparseArrayState(array, next);
> +    }
> +
Ditto.

> +    static StateBase* newObjectState(v8::Handle<v8::Object> object,
StateBase* next)
> +    {
> +	   // FIXME:
> +	   // - check not a wrapper
> +	   // - support File, etc.
> +	   return new ObjectState(object, next);
> +    }
Ditto.