[webkit-reviews] review requested: [Bug 29431] [Qt] REGRESSION:(r50665) QWebFrame::setScrollBarPolicy(Qt::Vertical, Qt::ScrollBarAlwaysOff) has no effect. : [Attachment 52517] patch 2 - addressed feedback from hyatt on IRC

[bugzilla-daemon at webkit.org]

Antonio Gomes (tonikitoo) <tonikitoo at webkit.org> has asked  for review:
Bug 29431: [Qt] REGRESSION:(r50665)
QWebFrame::setScrollBarPolicy(Qt::Vertical,Qt::ScrollBarAlwaysOff) has no
effect.
https://bugs.webkit.org/show_bug.cgi?id=29431

Attachment 52517: patch 2 - addressed feedback from hyatt on IRC
https://bugs.webkit.org/attachment.cgi?id=52517&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>
In IRC, it was agreed w/ hyatt to remove the optional 'lock' parameter from
ScrollView::setScrollingModes, since both set{Horizontal,Vertical}ScrollingMode
methods have the 'lock' parameter, which is enough to fixing the issue. The
former *has* honors the current lock state though.
 
It was also agreed Frame::createView could get two additional parameters for
vertical scrollbar lock and horizontal scrollbar lock respectively, to persist
the current lock state cross page loads.

patch 2 addresses these.