[webkit-reviews] review denied: [Bug 37025] Web Inspector: GC Run event should be added to Timeline Panel : [Attachment 52491] [patch] Initial version.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 3 09:46:11 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 37025: Web Inspector: GC Run event should be added to Timeline Panel
https://bugs.webkit.org/show_bug.cgi?id=37025

Attachment 52491: [patch] Initial version.
https://bugs.webkit.org/attachment.cgi?id=52491&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
- GCEventHelper.* are missing in the patch.
- Files that abstract us from the engine should start with Script* in case they
do not inherit common interface. It could be that ScriptDebugServer or
ScriptController should have the new methods.


More information about the webkit-reviews mailing list