[webkit-reviews] review requested: [Bug 37026] [Qt] WebKit does not build on Windows with --3d-canvas : [Attachment 52493] Windows compilation fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 3 02:59:03 PDT 2010


Jarkko Sakkinen <jarkko.j.sakkinen at gmail.com> has asked  for review:
Bug 37026: [Qt] WebKit does not build on Windows with --3d-canvas
https://bugs.webkit.org/show_bug.cgi?id=37026

Attachment 52493: Windows compilation fix
https://bugs.webkit.org/attachment.cgi?id=52493&action=review

------- Additional Comments from Jarkko Sakkinen <jarkko.j.sakkinen at gmail.com>
Note that I have commeted out UUID.cpp from WebCore. Including it in WebCore
causes linker error with out without 3d-canvas:

	link /LIBPATH:"c:\Qt\4.6.0\lib" /NOLOGO /INCREMENTAL:NO /DLL /MANIFEST
/MANIFESTFILE:"obj/release\QtWebKit.inter

mediate.manifest" /VERSION:4.60 /OUT:..\lib\QtWebKit4.dll
@C:\DOCUME~1\sakkijar\LOCALS~1\Temp\nmD1.tmp
   Creating library ..\lib\QtWebKit4.lib and object ..\lib\QtWebKit4.exp
UUID.obj : error LNK2019: unresolved external symbol __imp__StringFromGUID2 at 12
referenced in function "class WebCore::St

ring __cdecl WebCore::createCanonicalUUIDString(void)"
(?createCanonicalUUIDString at WebCore@@YA?AVString at 1@XZ)
UUID.obj : error LNK2019: unresolved external symbol __imp__CoCreateGuid at 4
referenced in function "class WebCore::String

 __cdecl WebCore::createCanonicalUUIDString(void)"
(?createCanonicalUUIDString at WebCore@@YA?AVString at 1@XZ)
..\lib\QtWebKit4.dll : fatal error LNK1120: 2 unresolved externals
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio
9.0\VC\BIN\link.EXE"' : return code '0x460'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio
9.0\VC\BIN\nmake.exe"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: 'cd' : return code '0x2'
Stop.

AND function createCanonicalUUIDString is not used in anyfile under webkit
tree.


More information about the webkit-reviews mailing list