[webkit-reviews] review granted: [Bug 36957] check-webkit-style: fails silently on non-existent files : [Attachment 52422] Proposed patch

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has granted Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 36957: check-webkit-style: fails silently on non-existent files
https://bugs.webkit.org/show_bug.cgi?id=36957

Attachment 52422: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=52422&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
> +	   if not os_path_exists(file_path):
> +	       _log.error("File does not exist: %s" % file_path)
> +	       return

Does this mean we won't terminate the program? If so, I slightly prefer to
raise an exception here. If a user invokes the style checker by

% check-webkit-style not_exist WebCore

the error message might be missed due to a lot of style errors in WebCore, I
guess.

Otherwise, looks good. Thanks for this change!