[webkit-reviews] review granted: [Bug 36574] Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation : [Attachment 52462] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 2 21:41:14 PDT 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Kenneth Russell
<kbr at google.com>'s request for review:
Bug 36574: Inconsistent failure modes from uniform[Matrix]* with null
WebGLUniformLocation
https://bugs.webkit.org/show_bug.cgi?id=36574
Attachment 52462: Patch
https://bugs.webkit.org/attachment.cgi?id=52462&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/html/canvas/WebGLRenderingContext.cpp
> + if (!location) {
> + m_context->synthesizeGLError(GraphicsContext3D::INVALID_VALUE);
> + return;
> + }
> +
> + if (location->program() != m_currentProgram) {
> m_context->synthesizeGLError(GraphicsContext3D::INVALID_OPERATION);
> return;
> }
R=me, but perhaps we should have a helper method for this replicated code.
More information about the webkit-reviews
mailing list