[webkit-reviews] review denied: [Bug 37008] ScriptController::processingUserGestureEvent returns true for simulated clicks : [Attachment 52474] patch (v3)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 2 20:43:49 PDT 2010
Adam Barth <abarth at webkit.org> has denied Andy Estes <aestes at apple.com>'s
request for review:
Bug 37008: ScriptController::processingUserGestureEvent returns true for
simulated clicks
https://bugs.webkit.org/show_bug.cgi?id=37008
Attachment 52474: patch (v3)
https://bugs.webkit.org/attachment.cgi?id=52474&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
+ namespace WebCore {
We usually have a blank line under the namespace declaration.
+ static inline bool processingUserGesture() { return s_processingUserGesture;
}
No need to declare inline here.
+ #include <new>
Why do we need this here?
Also, please fix the Chromium build failure. If you were a committer, I would
r+ your patch and ask you to fix these things on landing, but as a
non-committer, I'm going to ask you to upload a new patch so we can land it
using the bot.
Thanks for the patch.
More information about the webkit-reviews
mailing list