[webkit-reviews] review requested: [Bug 37053] WorkerGlobalScope.close() should let the currently running script complete execution, then terminate the worker. : [Attachment 52473] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 2 18:20:12 PDT 2010


Dmitry Titov <dimich at chromium.org> has asked  for review:
Bug 37053: WorkerGlobalScope.close() should let the currently running script
complete execution, then terminate the worker.
https://bugs.webkit.org/show_bug.cgi?id=37053

Attachment 52473: Patch.
https://bugs.webkit.org/attachment.cgi?id=52473&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
The WorkerContext::close() now disables future execution (but does not
interrupt current JS fragment) and posts a cleanup task that will eventually
call WorkerThread::stop().
Since WorkerContext::isClosed() returns true, all non-cleanup tasks that may
happen to be in the queue before StopWorkerContextTask will be thrown away w/o
execution.
Updated test to match.


More information about the webkit-reviews mailing list