[webkit-reviews] review granted: [Bug 36978] Very bad scrolling-performance with the Trackpad at http://www.apple.com/ipad/app-store/ : [Attachment 52466] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 36978: Very bad scrolling-performance with the Trackpad at
http://www.apple.com/ipad/app-store/
https://bugs.webkit.org/show_bug.cgi?id=36978

Attachment 52466: Patch
https://bugs.webkit.org/attachment.cgi?id=52466&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   // Check to see if the image changed; we have to do this because the
call to
> +	   // CGImageCreateCopyWithColorSpace() below can create a new image
every time.
> +	   if (m_uncorrectedContentsImage &&
CFEqual(m_uncorrectedContentsImage.get(), newImage))
> +	       return;

Wow, does CFEqual actually work on CGImages!? And it compares every bit?

> +	   m_uncorrectedContentsImage = m_pendingContentsImage = newImage;

Could you do these on separate lines? It's too easy to overlook the second
assignment when it's all on one line.

r=me assuming you tested