[webkit-reviews] review requested: [Bug 36961] Enable HTMLProgressElement for Safari on OSX : [Attachment 52458] Patch to address comment #14
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 2 15:22:30 PDT 2010
Yael <yael.aharon at nokia.com> has asked for review:
Bug 36961: Enable HTMLProgressElement for Safari on OSX
https://bugs.webkit.org/show_bug.cgi?id=36961
Attachment 52458: Patch to address comment #14
https://bugs.webkit.org/attachment.cgi?id=52458&action=review
------- Additional Comments from Yael <yael.aharon at nokia.com>
This patch addresses comment #14 but does not address the ColorSpace issue.
I suppose there are at least 2 ways to address that:
1. Do the same as ScrollbarThemeMac does and use DeviceColorSpace.
2. Do something like paintInfo.context->drawImage(imageBuffer->image(),
imageBuffer->context()->fillColorSpace(), rect.location());
But that would work only if HIThemeDrawTrack would set the color.
What do you think?
More information about the webkit-reviews
mailing list