[webkit-reviews] review requested: [Bug 35811] [chromium] need DragImage implementation : [Attachment 52445] space--

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 2 13:23:00 PDT 2010


Evan Stade <estade at chromium.org> has asked  for review:
Bug 35811: [chromium] need DragImage implementation
https://bugs.webkit.org/show_bug.cgi?id=35811

Attachment 52445: space--
https://bugs.webkit.org/attachment.cgi?id=52445&action=review

------- Additional Comments from Evan Stade <estade at chromium.org>
thanks for the tip

Parsing ChangeLog: /usr/local/google/WebKit/WebKit/chromium/ChangeLog
Parsing ChangeLog: /usr/local/google/WebKit/WebCore/ChangeLog
2010-04-01  Evan Stade	<estade at chromium.org>

	Reviewed by NOBODY (OOPS!).

	[chromium] need DragImage implementation
	https://bugs.webkit.org/show_bug.cgi?id=35811

	Use the DragImageRef that the DragController passes to us.

	* public/WebViewClient.h:
	(WebKit::WebViewClient::startDragging):
	* src/DragClientImpl.cpp:
	(WebKit::DragClientImpl::startDrag):
	* src/WebViewImpl.cpp:
	(WebKit::WebViewImpl::startDragging):
	* src/WebViewImpl.h:
2010-04-01  Evan Stade	<estade at chromium.org>

	Reviewed by NOBODY (OOPS!).

	[chromium] need DragImage implementation
	https://bugs.webkit.org/show_bug.cgi?id=35811

	Basic implementation using SkBitmap. Transformations are not supported
	yet. No implementation for mac.

	* WebCore.gyp/WebCore.gyp:
	* WebCore.gypi:
	* platform/chromium/DragImageChromium.cpp:
	* platform/chromium/DragImageRef.h:


More information about the webkit-reviews mailing list