[webkit-reviews] review denied: [Bug 37033] [chromium] font fallback for generic fonts picks wrong font : [Attachment 52431] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 2 12:59:45 PDT 2010


Eric Seidel <eric at webkit.org> has denied Evan Martin <evan at chromium.org>'s
request for review:
Bug 37033: [chromium] font fallback for generic fonts picks wrong font
https://bugs.webkit.org/show_bug.cgi?id=37033

Attachment 52431: Patch
https://bugs.webkit.org/attachment.cgi?id=52431&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
So i'm confused by why adding "-webkit-" makes the logic right.  I don't really
know what the "-webkit-" magic font family names are for?

Also, is this tested?  If so, how?  What tests need updates?  Is it not
possible to test due to needing a specific system config?

r- for the lack of testing or explanation thereof.


More information about the webkit-reviews mailing list