[webkit-reviews] review canceled: [Bug 33696] let's cache nodelists instead of dynamicnodelist::cache : [Attachment 51930] Inlining hasRareData check

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 2 12:00:28 PDT 2010


Eric Seidel <eric at webkit.org> has canceled  review:
Bug 33696: let's cache nodelists instead of dynamicnodelist::cache
https://bugs.webkit.org/show_bug.cgi?id=33696

Attachment 51930: Inlining hasRareData check
https://bugs.webkit.org/attachment.cgi?id=51930&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I'm not sure I'd call it insistence. :)  I tried on 3 other machine and failed
to reproduce the failure, so I stopped trusting the results from the
commit-queue.

Anton tried on several machines himself.  Marking cq- is actually worse than
marking r- as it would encourage someone to land this manually, where as the cq
is the only machine which  has seen this failure.

I'll clear the flags and you and Anton can hash it out.


More information about the webkit-reviews mailing list