[webkit-reviews] review granted: [Bug 36904] Clean up chromium WebNotificationPresenter interface after notification changes : [Attachment 52428] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Rafael Weinstein
<rafaelw at chromium.org>'s request for review:
Bug 36904: Clean up chromium WebNotificationPresenter interface after
notification changes
https://bugs.webkit.org/show_bug.cgi?id=36904

Attachment 52428: Patch
https://bugs.webkit.org/attachment.cgi?id=52428&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> diff --git a/WebKit/chromium/public/WebNotificationPresenter.h
b/WebKit/chromium/public/WebNotificationPresenter.h

> +    virtual Permission checkPermission(const WebURL& url) = 0;
The parameter name "url" adds no information so it shouldn't be present.

> +    virtual void requestPermission(const WebSecurityOrigin& origin,
WebNotificationPermissionCallback* callback) = 0;

"origin" and "callback" param names should be removed.