[webkit-reviews] review granted: [Bug 36063] Upload test result json files to app engine server : [Attachment 52304] Minor update to work with new autoinstall.py

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 2 09:47:55 PDT 2010


Adam Barth <abarth at webkit.org> has granted Victor Wang <victorw at chromium.org>'s
request for review:
Bug 36063: Upload test result json files to app engine server
https://bugs.webkit.org/show_bug.cgi?id=36063

Attachment 52304: Minor update to work with new autoinstall.py
https://bugs.webkit.org/attachment.cgi?id=52304&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Our experience with AppEngine is that you need to re-try writes because
AppEngine sometimes responds with 500 errors.  If you look in the
webkitpy.common.net package, you'll find a NetworkTransaction class that can
help with this.  You can look at example code to see how it works.  In any
case, that's a refinement we can do in a future patch.


More information about the webkit-reviews mailing list