[webkit-reviews] review requested: [Bug 36961] Enable HTMLProgressElement for Safari on OSX : [Attachment 52412] Patch, address comment #5

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 2 06:44:34 PDT 2010


Yael <yael.aharon at nokia.com> has asked	for review:
Bug 36961: Enable HTMLProgressElement for Safari on OSX
https://bugs.webkit.org/show_bug.cgi?id=36961

Attachment 52412: Patch, address comment #5
https://bugs.webkit.org/attachment.cgi?id=52412&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
(In reply to comment #5)
>>  # renderTheme is not ready to draw progress element
>>  fast/dom/HTMLProgressElement/progress-element.html
>> -fast/dom/HTMLProgressElement/set-progress-properties.html
>
>Why just one test, not both?

The animation causes the result of the pixel test to depend on the speed of
executing the test, and that will cause it to be flaky.
I introduced a manual test instead at WebCore/manual-tests/dom/progressbar.html


More information about the webkit-reviews mailing list