[webkit-reviews] review granted: [Bug 36817] Web Inspector [v8]: provide v8 binding for InspectorFrontendHost : [Attachment 52406] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 2 02:35:11 PDT 2010
Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 36817: Web Inspector [v8]: provide v8 binding for InspectorFrontendHost
https://bugs.webkit.org/show_bug.cgi?id=36817
Attachment 52406: patch
https://bugs.webkit.org/attachment.cgi?id=52406&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Could you merge WebDevToolsFrontendImpl and InspectorFrontendClientImpl? I
realize there is a life time clash, but I think we should fix this!
> +
> + Implement InspectorFrontendHost::showContextMenu for v8.
Use Web Inspector prefix.
>
> +#include "V8MouseEvent.h"
> #include "V8Binding.h"
Mind alphabetic order.
More information about the webkit-reviews
mailing list