[webkit-reviews] review requested: [Bug 36958] webkitpy: unit test the networktransaction log messages : [Attachment 52397] Proposed patch 2

[bugzilla-daemon at webkit.org]

Chris Jerdonek <cjerdonek at webkit.org> has asked  for review:
Bug 36958: webkitpy: unit test the networktransaction log messages
https://bugs.webkit.org/show_bug.cgi?id=36958

Attachment 52397: Proposed patch 2
https://bugs.webkit.org/attachment.cgi?id=52397&action=review

------- Additional Comments from Chris Jerdonek <cjerdonek at webkit.org>
Changed the patch to use a base class.

It seems possible that we could run into multiple inheritance issues down the
road with this change after all.

This is because it seems that the base class I created needs to itself inherit
from unittest.TestCase (as opposed to the calling class inheriting from both
this base class and unittest.TestCase).  Otherwise, the setUp() and tearDown()
methods of the base class don't seem to get fired.  If we ever needed to
inherit from unittest.TestCase twice in this way, I'm not sure whether unittest
will know to call the setUp() and tearDown() methods of both of the
unittest.TestCase super classes.