[webkit-reviews] review granted: [Bug 36995] Improve the error handling in rollout a bit : [Attachment 52365] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 1 20:36:47 PDT 2010
Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 36995: Improve the error handling in rollout a bit
https://bugs.webkit.org/show_bug.cgi?id=36995
Attachment 52365: Patch
https://bugs.webkit.org/attachment.cgi?id=52365&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Explain why in your comment, please:
# Note: Don't print a bug URL here because it will confuse the
259 # SheriffBot. Yes, that's lame.
260 log("Preparing rollout for bug %s." % commit_info.bug_id())
261
cc_list?
267 cc = sorted([party.bugzilla_email()
We should be passing around lists instead of a string:
273 "bug_cc": ",".join(cc),
Anyway, this looks fine. We should fix the cc passing around at some point.
Ideally now, but not required. Either way I don't need to see this again.
More information about the webkit-reviews
mailing list