[webkit-reviews] review granted: [Bug 36994] Avoid doing work in FrameView::scrollPositionChanged() if there are no fixed position elements : [Attachment 52358] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 1 19:45:02 PDT 2010


Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 36994: Avoid doing work in FrameView::scrollPositionChanged() if there are
no fixed position elements
https://bugs.webkit.org/show_bug.cgi?id=36994

Attachment 52358: Patch
https://bugs.webkit.org/attachment.cgi?id=52358&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    bool hasFixedObjects() const { return m_fixedObjectCount > 0; }

Since this is used only inside the class, can we make the function private?
Members generally should be as private as possible. Or maybe just say &&
m_fixedObjectCount at the call site?

r=me


More information about the webkit-reviews mailing list