[webkit-reviews] review granted: [Bug 37001] sheriffbot rollout should verify that the svn revision is a number. : [Attachment 52364] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 1 18:41:02 PDT 2010


Adam Barth <abarth at webkit.org> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 37001: sheriffbot rollout should verify that the svn revision is a number.
https://bugs.webkit.org/show_bug.cgi?id=37001

Attachment 52364: Patch
https://bugs.webkit.org/attachment.cgi?id=52364&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This is good, but I'm about to remove the IRC post of the ScriptError.	You
should add it back when you land this though.

Also, we should validate that the first character of reason isn't a "-".


More information about the webkit-reviews mailing list