[webkit-reviews] review denied: [Bug 36394] Include git commits in the diff for webkit-patch upload/land. : [Attachment 52305] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 36394: Include git commits in the diff for webkit-patch upload/land.
https://bugs.webkit.org/show_bug.cgi?id=36394

Attachment 52305: Patch
https://bugs.webkit.org/attachment.cgi?id=52305&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Ojan and I reviewed this in person.

r=me on the prepare-ChagneLog changes.
He's going to post a new patch with just the svn_branch_name, svn_merge_base,
delete_branch stuff and tests.
And I believe his plan is to re-write this to pass the individual options as
arguments to the various functions which need them.  Mostly some different
plumbing, but should be easier to understand than a stateful Git class.