[webkit-reviews] review granted: [Bug 36907] [Chromium] WebFrame should have a method to execute script and return the evaluated value : [Attachment 52221] Adding a method to WebFrame to evaluate a JS expression.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 1 16:27:48 PDT 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Jay Campan
<jcampan at google.com>'s request for review:
Bug 36907: [Chromium] WebFrame should have a method to execute script and
return the evaluated value
https://bugs.webkit.org/show_bug.cgi?id=36907
Attachment 52221: Adding a method to WebFrame to evaluate a JS expression.
https://bugs.webkit.org/attachment.cgi?id=52221&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebKit/chromium/public/WebFrame.h
...
> namespace v8 {
> class Context;
> +template <class T> class Handle;
> template <class T> class Local;
> +class Value;
> +
> }
nit: please change the above to:
namespace v8 {
class Context;
class Value;
template <class T> class Handle;
template <class T> class Local;
}
with that, R=me
More information about the webkit-reviews
mailing list