[webkit-reviews] review denied: [Bug 29431] [Qt] REGRESSION:(r50665) QWebFrame::setScrollBarPolicy(Qt::Vertical, Qt::ScrollBarAlwaysOff) has no effect. : [Attachment 52325] patch 1 - adds lock scrollbars concept to ScrollView

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>'s request for review:
Bug 29431: [Qt] REGRESSION:(r50665)
QWebFrame::setScrollBarPolicy(Qt::Vertical,Qt::ScrollBarAlwaysOff) has no
effect.
https://bugs.webkit.org/show_bug.cgi?id=29431

Attachment 52325: patch 1 - adds lock scrollbars concept to ScrollView
https://bugs.webkit.org/attachment.cgi?id=52325&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I would not alter any of the mode-setting functions.  Just add the lock
functions separately.  The mode-setting functions can of course check the
locks, but I don't think you should mix mode setting and locking in the same
functions.