[webkit-reviews] review requested: [Bug 32196] Make it possible to distinguish between NPAPI plugins and Application plugins : [Attachment 52327] Updated Patch

[bugzilla-daemon at webkit.org]

Robert Hogan <robert at webkit.org> has asked  for review:
Bug 32196: Make it possible to distinguish between NPAPI plugins and
Application plugins
https://bugs.webkit.org/show_bug.cgi?id=32196

Attachment 52327: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=52327&action=review

------- Additional Comments from Robert Hogan <robert at webkit.org>
OK, this is the result of my attempts to address the observations of ap and
abarth on the mailing list.

I've removed the check added to MimeTypeRegistry.

I've added a client->isPlugin(mimetype) function that ports can implement to
specify that a given mimetype should not be considered a plugin when plugins
are disabled.

The reasons I have not used client->allowPlugins() or
frameloader->allowPlugins() are:

- the check should only be made during requestObject(); 
- allowPlugins() is used elsewhere in WebCore where the mimetype is not
available; 
- allowPlugins() is called in situations where client-implemented plugins such
as Qt plugins are not relevant (e.g. DOMImplementation where a file could be
opened with a plugin, Page.cpp where it is getting data from the plugin);