[webkit-reviews] review canceled: [Bug 36862] Notifications should not resolve an empty icon parameter as a relative URL : [Attachment 52099] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 1 12:41:07 PDT 2010


Dmitry Titov <dimich at chromium.org> has canceled John Gregg
<johnnyg at google.com>'s request for review:
Bug 36862: Notifications should not resolve an empty icon parameter as a
relative URL
https://bugs.webkit.org/show_bug.cgi?id=36862

Attachment 52099: Patch
https://bugs.webkit.org/attachment.cgi?id=52099&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
> Index: WebCore/ChangeLog
> +
> +	   No new tests, code is disabled in WebKit.

This looks like something that has to be covered by a test. Especially if this
is a recent regression, as you say in the bug. The ENABLE_NOTIFICATIONS is
enabled in Chromium, so perhaps there is a way to have a test running at least
in chromium port?

Removing r? for now, feel free to flip back if there is a test or if it is
plain impossible to have one.


More information about the webkit-reviews mailing list