[webkit-reviews] review requested: [Bug 36971] [Qt]Add -Wextra warning level to the QtWebKit build : [Attachment 52312] proposed patch

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 36971: [Qt]Add -Wextra warning level to the QtWebKit build
https://bugs.webkit.org/show_bug.cgi?id=36971

Attachment 52312: proposed patch
https://bugs.webkit.org/attachment.cgi?id=52312&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
New warnings introduced - I propose to address these in a separate patch as
these warnings are not specific to the Qt port 

webkit/WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
In function 'bool pluginRemoveProperty(NPObject*, void*)':
webkit/WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:1
005: warning: no return statement in function returning non-void
webkit/WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
In function 'bool pluginEnumerate(NPObject*, void***, uint32_t*)':
webkit/WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:1
009: warning: no return statement in function returning non-void
webkit/WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
In function 'bool plugininConstruct(NPObject*, const NPVariant*, uint32_t,
NPVariant*)':
webkit/WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:1
013: warning: no return statement in function returning non-void