[webkit-reviews] review requested: [Bug 36958] webkitpy: unit test the networktransaction log messages : [Attachment 52293] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 1 07:38:59 PDT 2010


Chris Jerdonek <cjerdonek at webkit.org> has asked  for review:
Bug 36958: webkitpy: unit test the networktransaction log messages
https://bugs.webkit.org/show_bug.cgi?id=36958

Attachment 52293: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=52293&action=review

------- Additional Comments from Chris Jerdonek <cjerdonek at webkit.org>
Hi guys, this is all there is to it!

Note that the tearDown() method also asserts that the array of remaining log
messages is empty.  This checks that there are no unanticipated log messages
you *didn't* want to be present.  We get this extra check for free since it's
in the tearDown(). 

(Shinichiro, you've already seen this pattern a number of times, so let's let
Adam or Eric review it so we know at least one of them gets a chance to see it.
 Thanks!)


More information about the webkit-reviews mailing list