[webkit-reviews] review canceled: [Bug 36944] Chromium InspectorFrontendHost does not correctly implement canAttachWindow : [Attachment 52278] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 1 02:43:43 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has canceled Mattias Nissler
<mnissler at chromium.org>'s request for review:
Bug 36944: Chromium InspectorFrontendHost does not correctly implement
canAttachWindow
https://bugs.webkit.org/show_bug.cgi?id=36944

Attachment 52278: patch
https://bugs.webkit.org/attachment.cgi?id=52278&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
This looks good, although please look at my comments for the Chromium part. It
might be that we should go the other way in WebKit and remove canAttachWindow
as a whole. Clearing r? flag for now.


More information about the webkit-reviews mailing list