[webkit-reviews] review denied: [Bug 36944] Chromium InspectorFrontendHost does not correctly implement canAttachWindow : [Attachment 52277] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Mattias Nissler
<mnissler at chromium.org>'s request for review:
Bug 36944: Chromium InspectorFrontendHost does not correctly implement
canAttachWindow
https://bugs.webkit.org/show_bug.cgi?id=36944

Attachment 52277: Patch
https://bugs.webkit.org/attachment.cgi?id=52277&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Overall looks good. Could of nits that need to be fixed prior to landing.

> diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog
> index 551c957..aefd631 100644
> --- a/WebKit/chromium/ChangeLog
> +++ b/WebKit/chromium/ChangeLog
> @@ -1,3 +1,16 @@
> +2010-04-01  Mattias Nissler	<mnissler at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Implement canAttachWindow() for the WebDevToolsFrontendImpl
implementation of
> +	   InspectorFrontendHost and forward the call to
WebDevToolsFrontendClient. This
> +	   allows us to implement canAttachWindow() properly in the chromium
code.
> +

ChangeLog entry should reference bug url here.

> +    WebDevToolsFrontendImpl* frontend =
static_cast<WebDevToolsFrontendImpl*>(v8::External::Cast(*args.Data())->Value()
);
> +    frontend->m_client->sendDebuggerPauseScript();

No need to pause debugger for this one.