[webkit-reviews] review granted: [Bug 29943] 307 redirects should pass along http body and Content-Type header : [Attachment 40413] patch v1

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 29943: 307 redirects should pass along http body and Content-Type header
https://bugs.webkit.org/show_bug.cgi?id=29943

Attachment 40413: patch v1
https://bugs.webkit.org/attachment.cgi?id=40413&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
r=me with style issues to be fixed:

> Index: WebCore/platform/network/mac/ResourceHandleMac.mm
> ===================================================================
> --- WebCore/platform/network/mac/ResourceHandleMac.mm (revision 48858)
> +++ WebCore/platform/network/mac/ResourceHandleMac.mm (working copy)
> @@ -596,6 +596,15 @@ void ResourceHandle::receivedCancellatio
>	   if (!equalIgnoringCase(originalMethod, String([newRequest
HTTPMethod]))) {
>	       NSMutableURLRequest *mutableRequest = [newRequest mutableCopy];
>	       [mutableRequest setHTTPMethod:originalMethod];
> +	    
> +	       FormData* body = m_handle->request().httpBody();
> +	       if (!equalIgnoringCase(originalMethod, "GET") && body &&
!body->isEmpty())
> +		   WebCore::setHTTPBody(mutableRequest, body);
> +
> +	    String originalContentType = m_handle->request().httpContentType();

> +	    if (!originalContentType.isEmpty())
> +		[mutableRequest setValue:originalContentType
forHTTPHeaderField:@"Content-Type"];
> +
>	       newRequest = [mutableRequest autorelease];
>	   }
>      }

There's tabs here (and therefore, maybe elsewhere in the change?) - please
replace with spaces.  Maybe as a result, the indentation here is off.