[webkit-reviews] review granted: [Bug 29929] Need to check NULL frame in EventHandler::updateDragAndDrop. : [Attachment 40379] Proposed Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 29929: Need to check NULL frame in EventHandler::updateDragAndDrop.
https://bugs.webkit.org/show_bug.cgi?id=29929

Attachment 40379: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=40379&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -	       if (newTarget->hasTagName(frameTag) ||
newTarget->hasTagName(iframeTag))
> -		   accept =
static_cast<HTMLFrameElementBase*>(newTarget)->contentFrame()->eventHandler()->
updateDragAndDrop(event, clipboard);
> +	       Frame* frame = (newTarget->hasTagName(frameTag) ||
newTarget->hasTagName(iframeTag)) 
> +			       ?
static_cast<HTMLFrameElementBase*>(newTarget)->contentFrame() : 0;

We don't line up ? characters like this. In fact, I'm not sure why it's
indented the way it is. Just indent four characters as you would anywhere else.


r=me