[webkit-reviews] review denied: [Bug 29907] [Chromium] Incorrect conditions in WebCore.gyp : [Attachment 40336] Patch the collapses the two condition sections into one

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 30 09:14:15 PDT 2009


Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Chris Hawk
<hawk at chromium.org>'s request for review:
Bug 29907: [Chromium] Incorrect conditions in WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=29907

Attachment 40336: Patch the collapses the two condition sections into one
https://bugs.webkit.org/attachment.cgi?id=40336&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
This looks great, except:

> +	   Fix for conditionals in the WebCore gyp file, which contained two
separate
> +	   'conditions' values for the webcore target. The first entry was
ignored,
> +	   resulting in some missine defines.

Need bug URL.


More information about the webkit-reviews mailing list