[webkit-reviews] review requested: [Bug 29867] [Qt] QWebPage autotest has three failures : [Attachment 40363] idea of patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 30 05:35:50 PDT 2009
jedrzej.nowacki at nokia.com has asked for review:
Bug 29867: [Qt] QWebPage autotest has three failures
https://bugs.webkit.org/show_bug.cgi?id=29867
Attachment 40363: idea of patch
https://bugs.webkit.org/attachment.cgi?id=40363&action=review
------- Additional Comments from jedrzej.nowacki at nokia.com
Ok, results of "looking"...
testEnablePersistentStorage works after fix for 29844 bug.
test testOptionalJSObjects is broken because of DOMWindow.cpp. I attached
patch.
The patch SHOULD _NOT_ be committed, only reviewed. I think it is good, but it
was reverted in bug 28359
(https://bugs.webkit.org/show_bug.cgi?id=28359) because:
"made a change to return 'null' for window.applicationCache when the feature is
disabled in the preferences."
According to w3 documentation
(http://www.whatwg.org/specs/web-apps/current-work/#application-cache-api)
window.applicationCache should return an object to AplicationCache. So I think
it is pretty normal to return null if cache is disabled (there is no object).
so, why this patch is bad?
More information about the webkit-reviews
mailing list