[webkit-reviews] review granted: [Bug 29898] update-webkit --chromium fails to set .gclient file : [Attachment 40327] minor error handling changes

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Yaar Schnitman
<yaar at chromium.org>'s request for review:
Bug 29898: update-webkit --chromium fails to set .gclient file
https://bugs.webkit.org/show_bug.cgi?id=29898

Attachment 40327: minor error handling changes
https://bugs.webkit.org/attachment.cgi?id=40327&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> diff --git a/WebKitTools/Scripts/update-webkit
b/WebKitTools/Scripts/update-webkit

>  } elsif (isChromium()) {
> -    system("perl", "WebKitTools/Scripts/update-webkit-chromium") == 0 or
die;
> +    system("perl", "WebKitTools/Scripts/update-webkit-chromium") == 0 or die
$!;
>  } elsif (isAppleWinWebKit()) {
>      system("perl", "WebKitTools/Scripts/update-webkit-auxiliary-libs") == 0
or die;
>  }

Someday we may be able to use something other than "perl" here.  See Bug 29656
Comment #8.

r=me