[webkit-reviews] review granted: [Bug 29835] Sudden termination enabled a bit too eagerly when removing unload handlers : [Attachment 40275] comment

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Evan Stade <estade at chromium.org>'s
request for review:
Bug 29835: Sudden termination enabled a bit too eagerly when removing unload
handlers
https://bugs.webkit.org/show_bug.cgi?id=29835

Attachment 40275: comment
https://bugs.webkit.org/attachment.cgi?id=40275&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
The name is Mac OS X, not MacOSX.

I think the description makes things a bit more obscure than necessary. The
idea is that you call disableSuddenTermination first, then balance it with a
call to enableSuddenTermination. It's a programming error to call
enableSuddenTermination more times than you called disableSuddenTermination.

But it's good to have a comment.

Comment seems OK to land as-is, but it would be even better to fix either of
these things mentioned above.