[webkit-reviews] review requested: [Bug 29826] Add support for run-time flag for 3D canvas : [Attachment 40311] Revised patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has asked Dimitri Glazkov (Google)
<dglazkov at chromium.org> for review:
Bug 29826: Add support for run-time flag for 3D canvas
https://bugs.webkit.org/show_bug.cgi?id=29826

Attachment 40311: Revised patch
https://bugs.webkit.org/attachment.cgi?id=40311&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
@Chris Marrin:
> The use of the WebGL .exp file here is needed in order to allow the runtime
> flag conditional on the ENABLE_3D_CANVAS compile time flag. You could also
have
> the runtime flag always exist, like we did for the
> acceleratedCompositingEnabled runtime flag, while the functionality itself is

> conditionally compiled. That would allow you to get rid of the WebGL .exp
file.

That would simplify both this addition and its eventual removal once the WebGL
specification is finalized. Done.

@Dimitri Glazkov:
> You probably shouldn't remove the OOPS from here until reviewed. The
pre-commit
> hook makes it your last line of defense.

Done.

> Weird indentation here. Tabs maybe?

Yes, I didn't have tabs-as-spaces set for Change Log mode. Fixed.

> I didn't realize Win was a supported platform. If it's not, should we do this

> for all other ports, then?

Right now Safari only supports WebGL on Mac OS X, but I'm assuming Apple will
port it to Windows in the near future. I would prefer to leave the other ports
alone since the mechanism by which this flag is set will have to change
depending on how the browser vendor wants to expose it.