[webkit-reviews] review granted: [Bug 29749] Integrate chromium into update-webkit and build-webkit : [Attachment 40279] patch 5

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Yaar Schnitman
<yaar at chromium.org>'s request for review:
Bug 29749: Integrate chromium into update-webkit and build-webkit
https://bugs.webkit.org/show_bug.cgi?id=29749

Attachment 40279: patch 5
https://bugs.webkit.org/attachment.cgi?id=40279&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> diff --git a/WebKitTools/Scripts/build-webkit
b/WebKitTools/Scripts/build-webkit

> +sub writeCongrats();
>  sub formatBuildTime($);

These subroutine definitions should be in alphabetical order.

> +sub writeCongrats

Should be:  sub writeCongrats()

> diff --git a/WebKitTools/Scripts/update-webkit
b/WebKitTools/Scripts/update-webkit

>  my $getOptionsResult = GetOptions(
> -    'h|help'  => \$showHelp,
> -    'q|quiet' => \$quiet,
> +    'h|help'   => \$showHelp,
> +    'q|quiet'  => \$quiet,
>  ); 

These changes aren't needed now.

r=me

I'll land this.