[webkit-reviews] review denied: [Bug 29835] Sudden termination enabled a bit too eagerly when removing unload handlers : [Attachment 40272] sudden

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Evan Stade <estade at chromium.org>'s
request for review:
Bug 29835: Sudden termination enabled a bit too eagerly when removing unload
handlers
https://bugs.webkit.org/show_bug.cgi?id=29835

Attachment 40272: sudden
https://bugs.webkit.org/attachment.cgi?id=40272&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This change isn't needed on the normal Mac OS X version of WebKit. That's
because you can make multiple calls to disableSuddenTermination and
enableSuddenTermination, and only when you have balanced each
disableSuddenTermination call with an enableSuddenTermination call will it do
anything. I don't see any reason to merge together the before-unload set's
disableSuddenTermination call with the plain-old-unload set's
disableSuddenTermination.

Maybe there's a bug here, but this big a change is not needed to fix it.