[webkit-reviews] review denied: [Bug 29808] [Qt] assertions to be visible on Symbian : [Attachment 40236] vprintf patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Janne Koskinen
<koshuin at gmail.com>'s request for review:
Bug 29808: [Qt] assertions to be visible on Symbian
https://bugs.webkit.org/show_bug.cgi?id=29808

Attachment 40236: vprintf patch
https://bugs.webkit.org/attachment.cgi?id=40236&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog
> index f6a644a..894ff9a 100644
> --- a/JavaScriptCore/ChangeLog
> +++ b/JavaScriptCore/ChangeLog
> @@ -1,3 +1,15 @@
> +2009-09-28  Janne Koskinen  <janne.p.koskinen at digia.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   [Qt] Assert messages prints visible in Symbian
> +
> +	   Asserts use vprintf to print the messages to stderr.
> +	   In Symbian Open C it is not possible to see stderr so
> +	   I routed the messages to stdout instead.
> +
> +	   * wtf/Assertions.cpp:
> +

Please include a reference to the bug URL in the ChangeLog entry.

> +#ifdef PLATFORM(SYMBIAN)

This should be:

#if PLATFORM(SYMBIAN)

r- to address the above issues.