[webkit-reviews] review denied: [Bug 29749] Integrate chromium into update-webkit and build-webkit : [Attachment 40256] patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Yaar Schnitman <yaar at chromium.org>'s
request for review:
Bug 29749: Integrate chromium into update-webkit and build-webkit
https://bugs.webkit.org/show_bug.cgi?id=29749

Attachment 40256: patch
https://bugs.webkit.org/attachment.cgi?id=40256&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
run-chromium boiler plate seems premature, please remove.

I don't understand why build-webkit exits early for chromium?

I think the buildChromium stuff should move into wkdirs.pm like the rest of the
build functions are.  Yes, build-webkit his horribly factored these days. :(

I really really like making writeCongrats() its own function!  Glad you did
that.

Why?
 329	 
 330	 # Chromium can exit here.
 331	 exit $result;

Style:
 323	 }elsif (isLinux()) {

You might consider moving the chromium update stuff into its own script
"update-chromium-deps" or something?

Don't need to mark me as a reviewer.  That doesn't do anything in bugzilla, at
least not anything useful.  It tells other reviewers that they shouldn't review
something instead of telling me that I should.	It doesn't even send me an
email. :(