[webkit-reviews] review denied: [Bug 29797] [V8] Runaway JS recursion crashes Chromium workers on OS X : [Attachment 40218] Sets a stack limit. Do not land before proposed fix lands in V8--see description.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 28 11:19:45 PDT 2009


Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Dominic Cooney
<dominicc at google.com>'s request for review:
Bug 29797: [V8] Runaway JS recursion crashes Chromium workers on OS X
https://bugs.webkit.org/show_bug.cgi?id=29797

Attachment 40218: Sets a stack limit. Do not land before proposed fix lands in
V8--see description.
https://bugs.webkit.org/attachment.cgi?id=40218&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Sets a stack limit for V8 workers.
Need a better description of this test change and a bug URL.


>  
> +function h() {
> +    try {
> +	   g();
> +    } catch (ex) {
> +	   postMessage(ex);
> +    }
> +}
> +
>  try {
>      f();
>  } catch (ex) {
>      try {
>	   g();
>      } catch (ex) {
> -	   postMessage(ex);
> +	   setTimeout(h, 0);
>      }

perhaps this could be a new test?

> +	   Sets a stack limit for V8 workers.

Bug url is needed here. Also, make sure to prefix V8-related bug titles with
[V8].


More information about the webkit-reviews mailing list