[webkit-reviews] review requested: [Bug 28303] [Qt] XSLT support with QtXmlPatterns : [Attachment 40244] [Qt] Implement XSLT support with QtXmlPatterns.

[bugzilla-daemon at webkit.org]

Jakub Wieczorek <faw217 at gmail.com> has asked  for review:
Bug 28303: [Qt] XSLT support with QtXmlPatterns
https://bugs.webkit.org/show_bug.cgi?id=28303

Attachment 40244: [Qt] Implement XSLT support with QtXmlPatterns.
https://bugs.webkit.org/attachment.cgi?id=40244&action=review

------- Additional Comments from Jakub Wieczorek <faw217 at gmail.com>
(In reply to comment #47)
> (From update of attachment 39427 [details])
> 
> From what I can see this is very good, except for a tiny TransformSource
> buglet:
> 
> > -void Document::setTransformSource(void* doc)
> > +void Document::setTransformSource(TransformSource* source)
> >  {
> > -	 if (doc == m_transformSource)
> > -	     return;
> > -
> > -	 xmlFreeDoc((xmlDocPtr)m_transformSource);
> > -	 m_transformSource = doc;
> > +	 m_transformSource = source;
> >  }
> 
> Technically this function was protected against self-assignment and isn't
> anymore. One could
> argue it's a bug in OwnPtr perhaps?
> 
> > +	 void setTransformSource(TransformSource*);
> > +	 TransformSource* transformSource() const { return
m_transformSource.get(); }
> >  #endif
> 
> I believe the setter should take a PassOwnPtr<TransformSource>, to make it
safe
> and clear that ownership is passed here.

Done.